Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions and docs to conversions group #33

Merged
merged 1 commit into from
May 10, 2024

Conversation

42atomys
Copy link
Member

@42atomys 42atomys commented May 10, 2024

Description

This pull request introduces three new functions toBool, toUint and toUint64 to the conversion group

Changes

Fixes Masterminds#258, Masterminds#307

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

@42atomys 42atomys self-assigned this May 10, 2024
@42atomys 42atomys added aspect/dex 🤖 Concerns developers' experience with the codebase aspect/documentation 📚 Improvements or additions to documentation type/improvement ✨ Improvement to an existing feature labels May 10, 2024
@42atomys 42atomys added this to the v1.0 milestone May 10, 2024
Copy link

codecov bot commented May 10, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@42atomys 42atomys marked this pull request as ready for review May 10, 2024 20:55
@42atomys 42atomys merged commit 9533894 into main May 10, 2024
16 checks passed
@42atomys 42atomys deleted the feat/add-new-conversion-funcs branch May 10, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/dex 🤖 Concerns developers' experience with the codebase aspect/documentation 📚 Improvements or additions to documentation type/improvement ✨ Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How about a function toBool?
1 participant