Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce toduration conversion function #27

Merged
merged 1 commit into from
May 9, 2024

Conversation

42atomys
Copy link
Member

@42atomys 42atomys commented May 9, 2024

Description

This pull request introduce the toDuration as proposed in #8 and Masterminds#388 using the cast package.

Changes

  • Add the function toDuration

Fixes #8

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

@42atomys 42atomys linked an issue May 9, 2024 that may be closed by this pull request
@42atomys 42atomys self-assigned this May 9, 2024
@42atomys 42atomys added priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed aspect/dex 🤖 Concerns developers' experience with the codebase type/improvement ✨ Improvement to an existing feature labels May 9, 2024
@42atomys 42atomys added this to the v1.0 milestone May 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.7%. Comparing base (f253487) to head (75537b4).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #27   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files         13      13           
  Lines       1398    1401    +3     
=====================================
+ Hits        1394    1397    +3     
  Misses         2       2           
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@42atomys 42atomys merged commit a414bac into main May 9, 2024
12 checks passed
@42atomys 42atomys deleted the 8-proposal-add-toduration branch May 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/dex 🤖 Concerns developers' experience with the codebase priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed type/improvement ✨ Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: add toDuration
2 participants