Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer in screenshot #699

Merged
merged 12 commits into from
Aug 28, 2022
Merged

Fix nil pointer in screenshot #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
725f727
wip
alexferrari88 Aug 23, 2022
51e7142
Fix Panic in Screenshot #631
alexferrari88 Aug 25, 2022
8e90948
fix linter
ysmood Aug 25, 2022
3f66761
add doc for test
ysmood Aug 25, 2022
27b5ca4
update golangci-lint version
ysmood Aug 27, 2022
2ebfbaa
fix comments format
ysmood Aug 27, 2022
e51a888
fix comments format
ysmood Aug 27, 2022
2b199a3
fix comments format
ysmood Aug 27, 2022
189c3ca
make sure we can close the page while navigating
ysmood Aug 27, 2022
c39be30
use better site as example
ysmood Aug 27, 2022
cd5d9e8
Update README.md
Fly-Playgroud Aug 28, 2022
9dab6b2
Merge branch 'master' into bug/631
alexferrari88 Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions page.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,10 @@ func (p *Page) Screenshot(fullpage bool, req *proto.PageCaptureScreenshot) ([]by
return nil, err
}

if metrics.CSSContentSize == nil {
return nil, errors.New("failed to get css content size")
}

oldView := proto.EmulationSetDeviceMetricsOverride{}
set := p.LoadState(&oldView)
view := oldView
Expand Down
8 changes: 8 additions & 0 deletions page_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"github.com/go-rod/rod/lib/devices"
"github.com/go-rod/rod/lib/proto"
"github.com/go-rod/rod/lib/utils"
"github.com/ysmood/gson"
)

func TestGetPageBrowser(t *testing.T) {
Expand Down Expand Up @@ -657,6 +658,13 @@ func TestScreenshotFullPage(t *testing.T) {
g.mc.stubErr(1, proto.EmulationSetDeviceMetricsOverride{})
p.MustScreenshotFullPage()
})

g.Panic(func() {
g.mc.stub(1, proto.PageGetLayoutMetrics{}, func(send StubSend) (gson.JSON, error) {
return gson.New(proto.PageGetLayoutMetricsResult{}), nil
})
p.MustScreenshotFullPage()
ysmood marked this conversation as resolved.
Show resolved Hide resolved
})
}

func TestScreenshotFullPageInit(t *testing.T) {
Expand Down