Fix nil pointer in screenshot #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysmood
requested changes
Aug 27, 2022
ysmood
force-pushed
the
master
branch
2 times, most recently
from
747e746
to
635c06d
Compare
|
The PR looks good, can you pull the latest master and resolve the conflicts? |
I think I have managed... |
|
It's still not in sync with the master:
|
|
I guess it didn't refresh the page after I merged the changes :) |
ysmood
requested changes
Aug 28, 2022
Add Chinese repo entrance
ysmood
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is equivalent to #632 but has test coverage.
It fixes #631