Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: generate curl cmd for request && some examples that can be tested #728

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ahuigo
Copy link

@ahuigo ahuigo commented Oct 10, 2023

  1. New feature: generate curl cmd for request.
  1. Examples: they are also unit tests.

Feel free to close this PR if you think these codes are not suitable for merging into the main branch.

@jeevatkm
Copy link
Member

@ahuigo Thanks for your PR. Once v3.0.0 RC(s) is somewhat ready, I will return to your PR.

@ahuigo ahuigo force-pushed the examples branch 4 times, most recently from 606416e to 1c28236 Compare October 14, 2023 12:48
@jeevatkm
Copy link
Member

jeevatkm commented Oct 14, 2023

@ahuigo, I'm wondering, can you extract examples that are not related to current PR and create a separate PR targeting branch v2?

@ahuigo
Copy link
Author

ahuigo commented Oct 16, 2023

@ahuigo, I'm wondering, can you extract examples that are not related to current PR and create a separate PR targeting branch v2?

@jeevatkm Of course. Please review this PR(v2): #734

$ go test -failfast  ./examples
ok      github.com/go-resty/resty/v2/examples   (cached)

@ahuigo ahuigo changed the title New feature: generate curl cmd for request, and examples are tests New feature: generate curl cmd for request && some examples that can be tested Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants