Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EOF from multipart form file readers #438

Merged
merged 1 commit into from Sep 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion util.go
Expand Up @@ -202,7 +202,7 @@ func writeMultipartFormFile(w *multipart.Writer, fieldName, fileName string, r i
// Auto detect actual multipart content type
cbuf := make([]byte, 512)
size, err := r.Read(cbuf)
if err != nil {
if err != nil && err != io.EOF {
return err
}

Expand Down
16 changes: 16 additions & 0 deletions util_test.go
Expand Up @@ -5,6 +5,8 @@
package resty

import (
"bytes"
"mime/multipart"
"testing"
)

Expand Down Expand Up @@ -79,3 +81,17 @@ func TestIsXMLType(t *testing.T) {
}
}
}

func TestWriteMultipartFormFileReaderEmpty(t *testing.T) {
w := multipart.NewWriter(bytes.NewBuffer(nil))
defer func() { _ = w.Close() }()
if err := writeMultipartFormFile(w, "foo", "bar", bytes.NewReader(nil)); err != nil {
t.Errorf("Got unexpected error: %v", err)
}
}

func TestWriteMultipartFormFileReaderError(t *testing.T) {
err := writeMultipartFormFile(nil, "", "", &brokenReadCloser{})
assertNotNil(t, err)
assertEqual(t, "read error", err.Error())
}