Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: don't set created_at to now() by default for updates #125

Closed
wants to merge 4 commits into from

Conversation

KMPolakowski
Copy link
Contributor

fixes issue #110

@Fs02
Copy link
Member

Fs02 commented Oct 2, 2020

hmmm, the test fails because the result returned by db adapter contains location information, even though it's a zero time.
It's a valid result, but just hard to do the exact test. (fixable by only setting this value if not zero:

rel/convert.go

Line 54 in 3fb088c

*d = s
)

Edit: just noticed there's different problem for MySQL, where they don't accept 0000-00-00 as date time.
Edit: seems we need to rethink this solution based on the issue.

@KMPolakowski KMPolakowski reopened this Oct 15, 2020
@KMPolakowski KMPolakowski changed the title don't set created_at to now() by default for updates WIP: don't set created_at to now() by default for updates Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants