Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing non-HTTP payloads (#1) #80

Open
wants to merge 1 commit into
base: v5
Choose a base branch
from

Conversation

marcinwyszynski
Copy link
Contributor

Hey there, thanks for working on this! 馃檱馃檱馃檱

I have a use case where webhooks are hitting AWS Gateway and are ultimately pushed to an SQS queue that my application can handle asynchronously. This is useful to separate receiving and processing routines, as well as simplifies development because you no longer have to expose your local server to the Internet.

In order to use your excellent library with this approach, I split out the processing bit from Parse methods into ParsePayload ones, and made Parse methods use those to keep the API the same (and avoid writing extra tests 馃槀).

Please let me know if I can be of any further assistance and thanks again! 馃檱馃檱馃檱

@deankarn
Copy link
Collaborator

Awesome @marcinwyszynski !

Apologies for not commenting sooner, please give me some time to look it over, not a lot of free time ATM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants