Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed boolean validation to handle bool kind #988

Merged
merged 1 commit into from Sep 16, 2022
Merged

Fixed boolean validation to handle bool kind #988

merged 1 commit into from Sep 16, 2022

Conversation

V-R-Dighe
Copy link
Contributor

@V-R-Dighe V-R-Dighe commented Aug 18, 2022 •
edited

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@V-R-Dighe V-R-Dighe requested a review from a team as a code owner August 18, 2022 08:16
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 74.182% when pulling a193dc2 on V-R-Dighe:develop into 9e2ea40 on go-playground:master.

@V-R-Dighe V-R-Dighe mentioned this pull request Aug 22, 2022
Closed
1 task
@V-R-Dighe
Copy link
Contributor Author

Hello Team,
cc: @deankarn

Please review and let me know if anything more is needed from my end.

Thanks,
Vaibhav Dighe

@deankarn
Copy link
Contributor

Thanks for the reminder @V-R-Dighe sorry i just have very little time to maintain this project ATM.

will try to slip it in tomorrow.

@deankarn deankarn merged commit 1e8c614 into go-playground:master Sep 16, 2022
@kaushalnavneet kaushalnavneet mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@V-R-Dighe @coveralls @deankarn