Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validateMap invalid err msgs #962

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kaustubhbabar5
Copy link

@kaustubhbabar5 kaustubhbabar5 commented Jun 19, 2022

Fixes Or Enhances

Fixes #894.
errors from validateMap now contains the key on which the validations failed
fixes a case where Field() method associated with fieldError was returning empty string
edit: updated checkbox for tests below

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@kaustubhbabar5 kaustubhbabar5 requested a review from a team as a code owner June 19, 2022 11:10
@coveralls
Copy link

coveralls commented Jun 19, 2022

Coverage Status

coverage: 73.893% (-0.01%) from 73.903%
when pulling b24776d on kaustubhbabar5:fix-err-message-validateMap
into 84254ae on go-playground:master.

@0x46656C6978
Copy link

@kaustubhbabar5 I'm facing the problem error message when using ValidateMap and I see you PR here which can fix my problem. I'm wondering that can you resolve conflict and merge it please.

@kaustubhbabar5
Copy link
Author

@0x46656C6978 I have resolved the merge conflicts
@deankarn can you please review this

@saleh199
Copy link

@kaustubhbabar5 @0x46656C6978 any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid error messages with validateMap
4 participants