Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove underscore from RFC-1123 based regex #912

Merged
merged 3 commits into from May 1, 2022
Merged

fix: Remove underscore from RFC-1123 based regex #912

merged 3 commits into from May 1, 2022

Commits on Mar 15, 2022

  1. fix: Remove underscore from RFC-1123 based regex 

    RFC-1123 is based on RFC-952, which doesn't allow underscores. RFC-1123
must be therefore implemented with the same constraint to disallow
underscores in host names.
    @sdillen
    sdillen committed Mar 15, 2022
    Copy the full SHA
    329d5a5 View commit details
    Browse the repository at this point in the history

  2. test: Add test case for RFC-1123 validation 

    Add test case that covers constraint on underscores.
    @sdillen
    sdillen committed Mar 15, 2022
    Copy the full SHA
    b0c5b8c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Merge branch 'master' into fix/rfc1123

    @deankarn
    deankarn committed May 1, 2022
    Copy the full SHA
    d8e8d49 View commit details
    Browse the repository at this point in the history