Make docs for required more explicit regarding boolean values #1261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required
validates that the value is not the data types default zero value. Forboolean
the default zero value isfalse
. Therefore, afalse
boolean value would be interpreted as not matching therequired
validation and fail.This, in my opinion, is a little unexpected. Judging from the name
required
only, I expected that afalse
boolean value would be ok, since a value was provided.Nevertheless, in my opinion, this behavior should be documented a little more explicitly. Which is why I propose this change to the docs.
(this is only a docs change)
@go-playground/validator-maintainers