Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add required_if_contains, excluded_unless_contains and excluded_if_contains #1257

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lucasoares
Copy link

@lucasoares lucasoares commented Apr 25, 2024

Fixes Or Enhances

#1256

I didn't have too much time to check the current codebase to make sure my implementation fits the current contribution guidelines because I implemented this for a specific use case I had. I'm using it without issues for now...

I didn't like the function renaming I did to add a new parameter but I haven't thought of a better name and wanted to make sure it is compatible with previous implementations.

I haven't added translation for this tag, I have no idea how to do it and out of time right now, sorry

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@lucasoares lucasoares requested a review from a team as a code owner April 25, 2024 05:25
@coveralls
Copy link

coveralls commented Apr 25, 2024

Coverage Status

coverage: 74.259% (+0.05%) from 74.208%
when pulling fda6e97 on lucasoares:feat/contains
into a0f74b0 on go-playground:master.

@lucasoares lucasoares changed the title feat: add required_if_contains and excluded_if_contains feat: add required_if_contains, exclude_unless_contains and excluded_if_contains Apr 25, 2024
@lucasoares lucasoares changed the title feat: add required_if_contains, exclude_unless_contains and excluded_if_contains feat: add required_if_contains, excluded_unless_contains and excluded_if_contains Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants