Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB validator improved #1196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pixel365
Copy link

Enhances

Added MongoDB connection string validation

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@pixel365 pixel365 requested a review from a team as a code owner November 15, 2023 13:07
@coveralls
Copy link

coveralls commented Nov 15, 2023

Coverage Status

coverage: 74.179% (+0.3%) from 73.903%
when pulling 99a8d67 on pixel365:mongodb
into 84254ae on go-playground:master.

@deankarn
Copy link
Contributor

I'm not sure it would be best to have one validation do two different things, otherwise you wouldn't be able to differentiate for error messages and alike what exactly failed.

@pixel365
Copy link
Author

I'm not sure it would be best to have one validation do two different things, otherwise you wouldn't be able to differentiate for error messages and alike what exactly failed.

I agree with this remark. Added a separate tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants