Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation omitempty for empty String pointer #1173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix validation omitempty for empty String pointer #1173

wants to merge 1 commit into from

Conversation

nodivbyzero
Copy link
Contributor

Fixes Or Enhances

Do not make an interface check if a field is a String pointer.

Connected to #1129

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner September 23, 2023 01:16
@coveralls
Copy link

Coverage Status

coverage: 73.857% (+0.008%) from 73.849% when pulling 4e7ca28 on nodivbyzero:fix-omitempty-str-ptr into 8d50f2f on go-playground:master.

@nodivbyzero nodivbyzero mentioned this pull request Nov 1, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nodivbyzero @coveralls