Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Type called on zero reflect.Value #1156

Merged
merged 1 commit into from Aug 30, 2023
Merged

Fix Type called on zero reflect.Value #1156

merged 1 commit into from Aug 30, 2023

Conversation

MysteriousPotato
Copy link
Contributor

@MysteriousPotato MysteriousPotato commented Aug 30, 2023 •
edited

Fixes Or Enhances

#1155

Simply added back the check for invalid reflect types before calling Type on reflect.Value.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@MysteriousPotato
added invalid value check before calling Type
82faf77 
also added tests coverage for this case
@MysteriousPotato MysteriousPotato requested a review from a team as a code owner August 30, 2023 02:58
@coveralls
Copy link

Coverage Status

coverage: 73.849% (+0.006%) from 73.843% when pulling 82faf77 on MysteriousPotato:main into 1b40ba0 on go-playground:master.

@MysteriousPotato MysteriousPotato marked this pull request as draft August 30, 2023 03:29
@deankarn deankarn marked this pull request as ready for review August 30, 2023 04:59
@deankarn deankarn merged commit 75eeb3f into go-playground:master Aug 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MysteriousPotato @coveralls @deankarn