Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: oneof example's unclosed double quote #1148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: oneof example's unclosed double quote #1148

wants to merge 1 commit into from

Conversation

KaanSK
Copy link

@KaanSK KaanSK commented Aug 18, 2023 •
edited

Fixes

This really small PR fixes the unclosed doublequote in oneof example. When example is executed, it does not give error but skips oneof validation.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@KaanSK KaanSK requested a review from a team as a code owner August 18, 2023 10:34
@coveralls
Copy link

Coverage Status

coverage: 73.872%. remained the same when pulling ee0941e on KaanSK:master into 3094d59 on go-playground:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandear alexandear alexandear approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KaanSK @coveralls @alexandear