add validation for base64 url without = padding #1024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:
Change:
As flagged in this issue, validation fails for some strings encoded using base64.RawURLEncoding function.
The discussion around whether padding should be considered optional or not is rather long. Some of it can be found here: golang/go#4237. Following which, RawURLEncoding was introduced in base64 package.
The general rule of thumb regarding padding seems to be that you MUST be padding when encoding, but SHOULD be able to handle both padded and unpadded inputs when decoding. Therefore, we should provide support for validating unpadded encoded inputs.
Instead of modifying the "base64url" tag to accept unpadded inputs, it makes more sense to have a separate tag - "base64rawurl". This way it would be clear to the developer and they would use one or the other, or both back to back, depending on their usecase.
PS: formatting changes in doc.go because of go 1.19 updates. Please lmk if I should revert them.
Closes #1002
@go-playground/validator-maintainers