Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: support mongodb objectID validation #1023

Merged
merged 2 commits into from Mar 19, 2023
Merged

Feat: support mongodb objectID validation #1023

merged 2 commits into from Mar 19, 2023

Conversation

itzjustalan
Copy link
Contributor

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

I've tried adding a tag to validate mongodb objectIDs and I welcome any form of feedback.
Thanks.

@itzjustalan itzjustalan requested a review from a team as a code owner November 4, 2022 19:03
@coveralls
Copy link

coveralls commented Nov 4, 2022 •
edited

Coverage Status

Coverage: 74.262% (+0.007%) from 74.255% when pulling f6f1658 on itzjustalan:master into 29d50ba on go-playground:master.

@tomaswarynyca
Copy link

@deankarn are you considering adding this?

@Ks89
Copy link

Ks89 commented Mar 1, 2023

this pr could be very useful

@deankarn deankarn merged commit f560fd4 into go-playground:master Mar 19, 2023
@zemzale zemzale mentioned this pull request Mar 24, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@itzjustalan @coveralls @tomaswarynyca @Ks89 @deankarn