Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(New validator) Validate non-existing but valid file/directory paths #1022

Merged
merged 3 commits into from Mar 19, 2023

Conversation

johnnybubonic
Copy link
Contributor

NOTE: Because these are added as new validators, file and dir validator behavior remains the same/backwards compatibility is maintained.

Fixes Or Enhances

Fixes #808

  • Adds filepath and dirpath validators (for testing syntax validity of a path but not the required existence of it)
  • Slight modifications to file and dir validator documentation to disambiguate from the above.
  • Minor gofmt-ing (thanks, GoLand.)

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@johnnybubonic johnnybubonic requested a review from a team as a code owner October 31, 2022 05:22
@coveralls
Copy link

coveralls commented Oct 31, 2022

Coverage Status

Coverage: 74.273% (+0.01%) from 74.262% when pulling 55f7244 on johnnybubonic:master into f560fd4 on go-playground:master.

deankarn
deankarn previously approved these changes Mar 19, 2023
@deankarn deankarn merged commit 2e43671 into go-playground:master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] file validator fails if string is a valid filepath but does not exist
3 participants