Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Japanese translations of gte and lte #1012

Merged
merged 1 commit into from Mar 19, 2023

Conversation

jnst
Copy link
Contributor

@jnst jnst commented Oct 10, 2022

Fixes

In #898, the gte translation has been corrected to gt translation.
The original translation was correct, but the Japanese was ambiguously nuanced in a way that only a native Japanese speaker could understand.
I have therefore changed it to a clearer Japanese sentence.

For Japanese

#898 以前の元翻訳では、曖昧なニュアンスでしたが日本語としては合っていました。それが旧翻訳から gtelte の翻訳が gtlt の翻訳になってしまいました。
今回、新翻訳として 以上, 以下 を使うことで明確な日本語文に変更しました

  • 元翻訳: GteNumberは5.56かより大きくなければなりません
  • 旧翻訳: GteNumberは5.56より大きくなければなりません
  • 新翻訳: GteNumberは5.56以上でなければなりません

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@jnst jnst requested a review from a team as a code owner October 10, 2022 13:29
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.182% when pulling 6952e7a on jnst:fix-ja-translator into c7e0172 on go-playground:master.

@jnst jnst changed the title Fix the Japanese translations of gte and lte Fix Japanese translations of gte and lte Oct 10, 2022
@jnst jnst mentioned this pull request Oct 17, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants