fix(mangling): fixed name mangling when special chars are substituted #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes name mangling methods (ToJSONName, ToCommandName, etc) for cases when a special character is expanded, like so: "get$ref" should be jasonified as "getDollarRef". The issue was that the extra space added was not trimmed before name reconstruction, so in the example above, we get "getDollar Ref" instead. * contributes go-swagger/go-swagger#2821 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 12 12
Lines 1609 1609
=======================================
Hits 1375 1375
Misses 202 202
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Dec 27, 2023
…cter This PR fixes a special case when a "$" is inside a name AND we generate polymorphic types. In this case the unexported name was not properly generated (included a blank space). More generally, swag mangling functions fail to properly handle this extra blank space. Fortunately, ToGoName wasn't affected and this is why this failure occurs in such rare circumstances. * requires go-openapi/swag#78 * fixes go-swagger#2821 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
casualjim
approved these changes
Dec 27, 2023
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Dec 27, 2023
…cter This PR fixes a special case when a "$" is inside a name AND we generate polymorphic types. In this case the unexported name was not properly generated (included a blank space). More generally, swag mangling functions fail to properly handle this extra blank space. Fortunately, ToGoName wasn't affected and this is why this failure occurs in such rare circumstances. * requires go-openapi/swag#78 * fixes go-swagger#2821 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Dec 27, 2023
…cter This PR fixes a special case when a "$" is inside a name AND we generate polymorphic types. In this case the unexported name was not properly generated (included a blank space). More generally, swag mangling functions fail to properly handle this extra blank space. Fortunately, ToGoName wasn't affected and this is why this failure occurs in such rare circumstances. * requires go-openapi/swag#78 * fixes go-swagger#2821 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
added a commit
to go-swagger/go-swagger
that referenced
this pull request
Dec 27, 2023
…cter This PR fixes a special case when a "$" is inside a name AND we generate polymorphic types. In this case the unexported name was not properly generated (included a blank space). More generally, swag mangling functions fail to properly handle this extra blank space. Fortunately, ToGoName wasn't affected and this is why this failure occurs in such rare circumstances. * requires go-openapi/swag#78 * fixes #2821 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes name mangling methods (ToJSONName, ToCommandName, etc) for cases when a special character is expanded, like so: "get$ref" should be jasonified as "getDollarRef".
The issue was that the extra space added was not trimmed before name reconstruction, so in the example above, we get "getDollar Ref" instead.