fix: consume and publish blocked after rabbitmq reconnecting #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 7, 2022 20:16
xpunch
approved these changes
Apr 27, 2022
|
Could you also update to github.com/go-micro/plugins/v4/broker/rabbitmq? |
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, now consume and publish blocked after reconnecting. This can be replicated by restart rabbitmq.
For publish and consume , one go Channel may be blocked after the connection is disconnected.
For consume only, 'waitConnection' maybe the old value, and will blocked forever.
reference issue:
#rabbitmq/amqp091-go#18
In addition 'amqp.Channel.NotifyReturn' is not a connection or channel failed, so i removed the 'channelNotifyReturn'.
amqp-0-9-1-quickref
This method returns an undeliverable message that was published with the "immediate" flag set, or an unroutable message published with the "mandatory" flag set.