Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix some typos #16

wants to merge 1 commit into from

Conversation

Sen-Zhang
Copy link

@Sen-Zhang Sen-Zhang commented Sep 22, 2016 •
edited

Fix for #15

@Sen-Zhang
Copy link
Author

@unknwon Tests against Go 1.3 keep failing on travis.

@unknwon
Copy link
Contributor

unknwon commented Sep 22, 2016

Thanks, I'll remove 1.3 test.

Also, I think we should keep old typo method for a while and add a comment to remove it at some point, e.g. // TODO: remove after 2.0 release.

@unknwon unknwon mentioned this pull request Jul 21, 2019
Closed
@6543
Copy link
Contributor

6543 commented Oct 21, 2019

any progress?

@unknwon
Copy link
Contributor

unknwon commented Oct 23, 2019

I think merge would have to wait until we release macaron.v2, thus we'll have session.v2.

@6543
Copy link
Contributor

6543 commented Oct 23, 2019

@unknwon can you work with git-tag's on this repo for versions because of go1.13

thanks

@unknwon
Copy link
Contributor

unknwon commented Oct 24, 2019

can you work with git-tag's on this repo for versions because of go1.13

Not everyone is on Go 1.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feedback needed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sen-Zhang @unknwon @6543