Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destory => Destroy? #15

Open
lol768 opened this issue Aug 21, 2016 · 4 comments
Open

Destory => Destroy? #15

lol768 opened this issue Aug 21, 2016 · 4 comments
Labels
bug

Comments

@lol768
Copy link

lol768 commented Aug 21, 2016

Destory isn't a word, but I imagine this will break backwards compatibility?

https://github.com/go-macaron/session/blob/master/session.go#L57
@unknwon
Copy link
Contributor

unknwon commented Aug 23, 2016

Good point...

@unknwon unknwon added the bug label Aug 23, 2016
@Sen-Zhang Sen-Zhang mentioned this issue Sep 22, 2016
Open
@mjtrangoni
Copy link

How about fixing this? I know this is exported, but It is always confuse reading Destory for a Destroy action. It could be fixed in a major release.

@unknwon
Copy link
Contributor

unknwon commented Apr 16, 2018

@mjtrangoni yes, that's why the issue is still not fixed by no major release is planned anytime soon...

@unknwon unknwon mentioned this issue Jul 21, 2019
Closed
@unknwon
Copy link
Contributor

unknwon commented Jul 21, 2019

Using Go Modules and push out a v2 release seems ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjtrangoni @lol768 @unknwon