static: surround ETag with quotes (#194)

go-macaron · Apr 28, 2020 · 002c0ce · 002c0ce
1 parent bbb5ca2
commit 002c0ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/static.go b/static.go
@@ -178,7 +178,7 @@ func staticHandler(ctx *Context, log *log.Logger, opt StaticOptions) bool {
 
 	if opt.ETag {
 		tag := GenerateETag(string(fi.Size()), fi.Name(), fi.ModTime().UTC().Format(http.TimeFormat))
-		ctx.Resp.Header().Set("ETag", tag)
+		ctx.Resp.Header().Set("ETag", `"`+tag+`"`)
 	}
 
 	http.ServeContent(ctx.Resp, ctx.Req.Request, file, fi.ModTime(), f)

diff --git a/static_test.go b/static_test.go
@@ -201,7 +201,7 @@ func Test_Static_Options(t *testing.T) {
 		m.ServeHTTP(resp, req)
 		tag := GenerateETag(string(resp.Body.Len()), "macaron.go", resp.Header().Get("last-modified"))
 
-		So(resp.Header().Get("ETag"), ShouldEqual, tag)
+		So(resp.Header().Get("ETag"), ShouldEqual, `"`+tag+`"`)
 	})
 }