Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go.mod to 1.16 #56

Merged
merged 1 commit into from
Jun 13, 2021
Merged

bump go.mod to 1.16 #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/go-logr/logr

go 1.14
go 1.16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thockin: I know considered this a "trivial" change, but the reason for it is not clear to me. Why was it done, and why 1.16?

The "go" directive in a go.mod file does not specify a minimum compiler version, but rather the version of the Go language as used in the project: golang/go#30791

I'm not sure what that means for functions only added in later releases. Those are not language features, are they?