fix(sd): support ipv6 for consul and eureka #1274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now IPv6 + port in instances will be string like
2001:db8:1::ab9:C0A8:102:8000(8000 is the port) for consul and eureka. The correct instance should be like[2001:db8:1::ab9:C0A8:102]:8000, otherwise the HTTP call will fail.I also checked other sd. It's correct in dnssrv already:
kit/sd/dnssrv/instancer.go
Line 99 in 23eb35b
Other sd seem don't have this problem either like etcd and zk.