Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resubmit #1064 #1168

Merged
merged 6 commits into from Aug 19, 2021
Merged

Resubmit #1064 #1168

merged 6 commits into from Aug 19, 2021

Commits on Aug 19, 2021

  1. Fix unnecessary calls to Printf

    @withshubh @sagikazarmark
    withshubh authored and sagikazarmark committed Aug 19, 2021
    Copy the full SHA
    abd72ba View commit details
    Browse the repository at this point in the history

  2. Fix nil context being passed to function

    @withshubh @sagikazarmark
    withshubh authored and sagikazarmark committed Aug 19, 2021
    Copy the full SHA
    5550f4e View commit details
    Browse the repository at this point in the history

  3. Remove empty default in select

    @withshubh @sagikazarmark
    withshubh authored and sagikazarmark committed Aug 19, 2021
    Copy the full SHA
    d53f8e6 View commit details
    Browse the repository at this point in the history

  4. Replace bytes.Compare with bytes.Equal

    @withshubh @sagikazarmark
    withshubh authored and sagikazarmark committed Aug 19, 2021
    Copy the full SHA
    6e5c91d View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary use of fmt.Sprintf

    @withshubh @sagikazarmark
    withshubh authored and sagikazarmark committed Aug 19, 2021
    Copy the full SHA
    5d96968 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary hot loop 

    Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
    @sagikazarmark
    sagikazarmark committed Aug 19, 2021
    Copy the full SHA
    1c0d7c9 View commit details
    Browse the repository at this point in the history