Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nats test panics #1122

Merged
merged 2 commits into from Jun 30, 2021
Merged

Fix nats test panics #1122

merged 2 commits into from Jun 30, 2021

Commits on Jun 24, 2021

  1. test(transport/nats): remove nats server address log line 

    The running bit is set way earlier than the listener
that s.Addr returns. This lead to panics on several
occasions when the listener was not yet set.

Moving after ReadyForConnections could be a solution,
but logging the nats server address does not add
much to the test anyway: the address is logged
if there is an error.

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
    @sagikazarmark
    sagikazarmark committed Jun 24, 2021
    Copy the full SHA
    da4f1d0 View commit details
    Browse the repository at this point in the history

  2. test(transport/nats): remove unused code 

    Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
    @sagikazarmark
    sagikazarmark committed Jun 24, 2021
    Copy the full SHA
    835cefb View commit details
    Browse the repository at this point in the history