upgrade nats-server #1082
Closed
upgrade nats-server #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NATS Server ddos: * Version 2 prior to 2.2.0 + 2.0.0 through and including 2.1.9 are vulnerable * fixed with nats-io/nats-server commit 423b79440c (2021-03-14)
|
This seems fine to me, but it should be noted that go-kit only uses nats-server in tests. Also, this change will not propagate to to go-kit dependents until we tag a new release and we should check our go.mod for out of date dependencies when we are preparing a new go-kit release anyway. |
|
Would it make sense to rewrite those tests to use an external nats server instance (similarly to etcd, zookeeper, etc)? I understand the value of self-contained tests, but this could make the dependency graph smaller. |
|
@AbhilashVijayakumar Ping :) Can you fix the tests, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade NATS Server due to ddos vulnerability :
refer https://advisories.nats.io/CVE/CVE-2021-3127.txt