Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing.opentracing endpoint middleware options #1072

Merged
merged 9 commits into from May 7, 2021
Merged

tracing.opentracing endpoint middleware options #1072

merged 9 commits into from May 7, 2021

Commits on Mar 22, 2021

  1. refactor(tracing.opentracing): add endpoint tracing options 

    - optionally trace business errors
- add option to set static/dynamic tags
- add option to set dynamic name
    @alebabai
    alebabai committed Mar 22, 2021
    Copy the full SHA
    377c235 View commit details
    Browse the repository at this point in the history

  2. test(tracing.opentracing): cover endpoint options

    @alebabai
    alebabai committed Mar 22, 2021
    Copy the full SHA
    038371b View commit details
    Browse the repository at this point in the history

  3. update comments

    @alebabai
    alebabai committed Mar 22, 2021
    Copy the full SHA
    185f2f8 View commit details
    Browse the repository at this point in the history

  4. refactor(tracing.opentracing): options improvements 

    - some renaming
- more flexible tags option: support adding tags with multiple options
    @alebabai
    alebabai committed Mar 22, 2021
    Copy the full SHA
    af43370 View commit details
    Browse the repository at this point in the history

  5. refactor(tracing.opentracing): add TraceEndpoint function 

    - TraceServer and TraceClient should differ only in span kind tag value
- remain TraceServer and TraceClient for backward compatibility
    @alebabai
    alebabai committed Mar 22, 2021
    Copy the full SHA
    a4dd947 View commit details
    Browse the repository at this point in the history

  6. fix imports

    @alebabai
    alebabai committed Mar 22, 2021
    Copy the full SHA
    4af2b54 View commit details
    Browse the repository at this point in the history

  7. fix lint

    @alebabai
    alebabai committed Mar 22, 2021
    Copy the full SHA
    b8df650 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. refactor(tracing.opentracing): use ContextWithSpan after applying tags 

    just cosmetics
    @alebabai
    alebabai committed Apr 5, 2021
    Copy the full SHA
    93f53b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. refactor(tracing.opentracing): standardize 

    - support lb.Retry errors
- add more logging fields as it done in opencensus
- log business error anyway
- improve codebase
- fix typo
- add more test cases
    @alebabai
    alebabai committed Apr 19, 2021
    Copy the full SHA
    e5c83b1 View commit details
    Browse the repository at this point in the history