Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the ClientAfter calls to before the decode #1008

Merged
merged 2 commits into from Sep 4, 2020
Merged

Move the ClientAfter calls to before the decode #1008

merged 2 commits into from Sep 4, 2020

Commits on Aug 26, 2020

  1. Move the ClientAfter calls to before the decode 

    ClientAfter is documented as running _prior_ to being decoded. But, this
was only partly true. They were run prior to decode, but after the
jsonrpc unmarshalling,

As the callback uses the bare response object, and at least for me, is
used to debug what's seen on the wire, this seems incorrect.
    @directionless
    directionless committed Aug 26, 2020
    Copy the full SHA
    32b30c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. tests

    @directionless
    directionless committed Aug 29, 2020
    Copy the full SHA
    319b55c View commit details
    Browse the repository at this point in the history