Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid endpoint no return error #1005

Closed
wants to merge 1 commit into from
Closed

fix invalid endpoint no return error #1005

wants to merge 1 commit into from

Conversation

yyong37
Copy link

@yyong37 yyong37 commented Aug 18, 2020

pass "grpc.WithBlock()" to block until the underlying connection is up.

@yyong37
fix invalid endpoint no return error
caf3e27 
pass "grpc.WithBlock()" to block until the underlying connection is up.
@peterbourgon
Copy link
Member

Thanks for the PR! Please be sure to gofmt the code, and please include a test which fails on master and succeeds on your branch.

@peterbourgon
Copy link
Member

Ping :)

@sagikazarmark
Copy link
Contributor

#1009 might fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yyong37 @peterbourgon @sagikazarmark