Add Version to JSON-RPC client request (#990)

go-kit · Jun 15, 2020 · b1d0a5d · b1d0a5d
1 parent ef2f77e
commit b1d0a5d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/transport/http/jsonrpc/client.go b/transport/http/jsonrpc/client.go
@@ -164,7 +164,7 @@ func (c Client) Endpoint() endpoint.Endpoint {
 			return nil, err
 		}
 		rpcReq := clientRequest{
-			JSONRPC: "",
+			JSONRPC: Version,
 			Method:  c.method,
 			Params:  params,
 			ID:      c.requestID.Generate(),

diff --git a/transport/http/jsonrpc/client_test.go b/transport/http/jsonrpc/client_test.go
@@ -133,6 +133,9 @@ func TestClientHappyPath(t *testing.T) {
 	if id, _ := requestAtServer.ID.Int(); id != wantID {
 		t.Fatalf("Request ID at server: want=%d, got=%d", wantID, id)
 	}
+	if requestAtServer.JSONRPC != jsonrpc.Version {
+		t.Fatalf("JSON-RPC version at server: want=%s, got=%s", jsonrpc.Version, requestAtServer.JSONRPC)
+	}
 
 	var paramsAtServer addRequest
 	err = json.Unmarshal(requestAtServer.Params, &paramsAtServer)