Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an empty array from ValueWithShadows if there is none #313

Merged
merged 7 commits into from Jan 20, 2022
Merged

Return an empty array from ValueWithShadows if there is none #313

merged 7 commits into from Jan 20, 2022

Commits on Jan 8, 2022

  1. Return an empty array from ValueWithShadows if there are none

    @NDagestad
    NDagestad committed Jan 8, 2022
    Copy the full SHA
    0e2a128 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Change the way of deciding if a value should be returned or not 

    With the previous behaviour, many tests broke because it was not able to
distinguish between a key that was present but had no value and a key
that was not present at all.
    @NDagestad
    NDagestad committed Jan 15, 2022
    Copy the full SHA
    6ed3295 View commit details
    Browse the repository at this point in the history

  2. Trailing whitespaces should not be trimed in test files

    @NDagestad
    NDagestad committed Jan 15, 2022
    Copy the full SHA
    ce6c1ab View commit details
    Browse the repository at this point in the history

  3. Add tests for ValueWithShadows

    @NDagestad
    NDagestad committed Jan 15, 2022
    Copy the full SHA
    9fca1cd View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. revert to the original decision behaviour for ValueWithShadows 

    File.WriteToBuffer also needed to be tweaked so it could work with keys
that are present but have no value.
    @NDagestad
    NDagestad committed Jan 17, 2022
    Copy the full SHA
    12524e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Extract the value writting logic to an function to prevent code dupli… 

    …cation in WriteToBuffer
    @NDagestad
    NDagestad committed Jan 19, 2022
    Copy the full SHA
    d77100b View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Update file.go

    @unknwon
    unknwon committed Jan 20, 2022
    Copy the full SHA
    3b04438 View commit details
    Browse the repository at this point in the history