fix: translate SQLITE_CONSTRAINT_PRIMARYKEY to ErrDuplicatedKey #152
Conversation
|
Hi @bfabio Can you fix the conflicts? thank you |
Translate the SQLITE_CONSTRAINT_PRIMARYKEY error code to ErrDuplicatedKey as well for consistency.
bfabio
force-pushed
the
primary-key-constraint
branch
from
43d64da
to
57d2544
Compare
|
@jinzhu sure, done |
| @@ -7,6 +7,7 @@ import ( | |||
| ) | |||
|
|
|||
| var errCodes = map[int]error{ | |||
| 1555: gorm.ErrDuplicatedKey, | |||
There was a problem hiding this comment.
This is not DuplicatedKey violation error, please check out this https://www.sqlite.org/rescode.html#constraint_primarykey
There was a problem hiding this comment.
@jinzhu what do you think if we add a new CONSTRAINT_PRIMARYKEY error instead of using the same ErrDuplicatedKey?
There was a problem hiding this comment.
How about other databases, do they have any error code like CONSTRAINT_PRIMARYKEY, if not we can use the same one.
There was a problem hiding this comment.
I couldn't find this error type for Postgres and MySQL, @bfabio feel free to continue with your PR.
Mysql error codes: https://dev.mysql.com/doc/mysql-errors/8.0/en/server-error-reference.html
Postgres error codes: https://www.postgresql.org/docs/current/errcodes-appendix.html
What did this pull request do?
Translate the SQLITE_CONSTRAINT_PRIMARYKEY error code to ErrDuplicatedKey as well for consistency.
User Case Description
We refactored our code to take advantage of ErrDuplicatedKey, but the tests fail because ErrDuplicatedKey only gets returned for non primary key fields (and it should IMO):
italia/developers-italia-api#197
https://github.com/italia/developers-italia-api/actions/runs/5143820348/jobs/9259314436?pr=197
Also, should this go in https://github.com/go-gorm/postgres and https://github.com/go-gorm/mysql as well?