Fix same type comparing #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fieldColumnType.DatabaseTypeName()` returns non capitalized string, while `fileType.SQL` returns capitalized string. This commit aims to fix this and avoid detecting a type change when the type did not change.
|
Maybe I could call strings.ToUpper on both expressions, instead of only on |
jinzhu
reviewed
Mar 18, 2024
migrator.go
Outdated
| @@ -312,7 +312,7 @@ func (m Migrator) AlterColumn(value interface{}, field string) error { | |||
| fileType := clause.Expr{SQL: m.DataTypeOf(field)} | |||
| // check for typeName and SQL name | |||
| isSameType := true | |||
| if fieldColumnType.DatabaseTypeName() != fileType.SQL { | |||
| if strings.ToUpper(fieldColumnType.DatabaseTypeName()) != fileType.SQL { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, nice catch ! Updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fieldColumnType.DatabaseTypeName()returns non capitalized string, whilefileType.SQLreturns capitalized string. This commit aims to fix this and avoid detecting a type change when the type did not change.What did this pull request do?
Fix same type comparing when running auto-migrate
User Case Description
When running auto migrate, we detected we ended up attempting to execute the statement.
This resulted in an error since our database (CockroachDB) does not allow type alter statements on JSONB columns.
After reviewing the code and debugging, I noticed that this behaviour was due to this comparison.
fieldColumnType.DatabaseTypeName()returns non capitalised string, whilefileType.SQLreturns capitalised string.After using
strings.ToUpperonfieldColumnType.DatabaseTypeName()before comparing it tofileType.SQL, this type change is no longer detected and auto-migrate succeeds.This PR aims to fix this and avoid detecting a type change when the type did not change.