add USING ?::? to AlterColumn (#105)

Co-authored-by: Jinzhu <wosmvp@gmail.com>
go-gorm · Oct 8, 2022 · a4858c5 · a4858c5
1 parent 096c357
commit a4858c5
Showing 1 changed file with 26 additions and 22 deletions.
diff --git a/migrator.go b/migrator.go
@@ -279,31 +279,35 @@ func (m Migrator) AlterColumn(value interface{}, field string) error {
 				}
 			}
 
-			fileType := clause.Expr{SQL: m.DataTypeOf(field)}
-			if fieldColumnType.DatabaseTypeName() != fileType.SQL {
-				filedColumnAutoIncrement, _ := fieldColumnType.AutoIncrement()
-				if field.AutoIncrement && filedColumnAutoIncrement { // update
-					serialDatabaseType, _ := getSerialDatabaseType(fileType.SQL)
-					if t, _ := fieldColumnType.ColumnType(); t != serialDatabaseType {
-						if err := m.UpdateSequence(m.DB, stmt, field, serialDatabaseType); err != nil {
+			return m.DB.Connection(func(tx *gorm.DB) error {
+				fileType := clause.Expr{SQL: m.DataTypeOf(field)}
+				if fieldColumnType.DatabaseTypeName() != fileType.SQL {
+					filedColumnAutoIncrement, _ := fieldColumnType.AutoIncrement()
+					if field.AutoIncrement && filedColumnAutoIncrement { // update
+						serialDatabaseType, _ := getSerialDatabaseType(fileType.SQL)
+						if t, _ := fieldColumnType.ColumnType(); t != serialDatabaseType {
+							if err := m.UpdateSequence(tx, stmt, field, serialDatabaseType); err != nil {
+								return err
+							}
+						}
+					} else if field.AutoIncrement && !filedColumnAutoIncrement { // create
+						serialDatabaseType, _ := getSerialDatabaseType(fileType.SQL)
+						if err := m.CreateSequence(tx, stmt, field, serialDatabaseType); err != nil {
+							return err
+						}
+					} else if !field.AutoIncrement && filedColumnAutoIncrement { // delete
+						if err := m.DeleteSequence(tx, stmt, field, fileType); err != nil {
+							return err
+						}
+					} else {
+						if err := tx.Exec("ALTER TABLE ? ALTER COLUMN ? TYPE ? USING ?::?",
+							m.CurrentTable(stmt), clause.Column{Name: field.DBName}, fileType, clause.Column{Name: field.DBName}, fileType).Error; err != nil {
 							return err
 						}
-					}
-				} else if field.AutoIncrement && !filedColumnAutoIncrement { // create
-					serialDatabaseType, _ := getSerialDatabaseType(fileType.SQL)
-					if err := m.CreateSequence(m.DB, stmt, field, serialDatabaseType); err != nil {
-						return err
-					}
-				} else if !field.AutoIncrement && filedColumnAutoIncrement { // delete
-					if err := m.DeleteSequence(m.DB, stmt, field, fileType); err != nil {
-						return err
-					}
-				} else {
-					if err := m.DB.Exec("ALTER TABLE ? ALTER COLUMN ? TYPE ?", m.CurrentTable(stmt), clause.Column{Name: field.DBName}, fileType).Error; err != nil {
-						return err
 					}
 				}
-			}
+				return nil
+			})
 
 			if null, _ := fieldColumnType.Nullable(); null == field.NotNull {
 				if field.NotNull {
@@ -691,4 +695,4 @@ func groupByIndexName(indexList []*Index) map[string][]*Index {
 
 func (m Migrator) GetTypeAliases(databaseTypeName string) []string {
 	return typeAliasMap[databaseTypeName]
-}
+}