fix(scan): update setupValuerAndSetter to use default values when pointer t… #6938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waldeedle
force-pushed
the
master
branch
2 times, most recently
from
c1afb54
to
88330cb
Compare
Waldeedle
changed the title
|
@jinzhu any concerns with this PR? |
|
@a631807682 am I missing something for this to be reviewed? |
jinzhu
reviewed
Apr 26, 2024
| fieldIsEmbeddedPointerTypeStruct := len(field.BindNames) > 1 && len(field.StructField.Index) > 0 && field.StructField.Index[0] < 0 | ||
| fieldValue := reflect.ValueOf(values[idx]).Elem() | ||
| if !fieldIsEmbeddedPointerTypeStruct && fieldValue.Kind() == reflect.Ptr && fieldValue.IsNil() { | ||
| db.AddError(field.Set(db.Statement.Context, reflectValue, field.DefaultValueInterface)) |
There was a problem hiding this comment.
Why use field.DefaultValueInterface? I don't think it is an expected behavior for most users.
There was a problem hiding this comment.
field.DefaultValueInterface ensures that I return the struct back with default/zero values for each field. i.e. nil for pointers and 0 for ints. It helps to reset the struct.
There was a problem hiding this comment.
@jinzhu any concerns with that?
There was a problem hiding this comment.
@jinzhu
I think it is expected usage based on your docs: https://gorm.io/docs/sql_builder.html#Scan-sql-Rows-into-struct
var user User
for rows.Next() {
// ScanRows scan a row into user
db.ScanRows(rows, &user)
// do something
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Addresses #6819
Adding the else condition to use the base type when data is nil ensures that the struct field is always set by the scanIntoStructMethod
User Case Description
It fixes the example from the docs where you initialize the var once: