fix: endless loop in save #6800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a631807682
reviewed
Jan 22, 2024
There was a problem hiding this comment.
Thanks for your contribution, we are sure this is a bug and it comes from 0729261, can you add some tests for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Save attempts to dereference an interface using reflect.Indirect this doesn't work as that is only intended for pointers.
This change stops it from trying to do that. Trying to do this will instead result in an error.
I don't think this should cause any breaking changes, but I don't know why this code was written like.
This would close Issue #6799 but if another solution for the problem would be preferred feel free to close this pull request.
User Case Description
While it might not be a supported case to call Save with a pointer to an interface it should not cause an endless loop.