Use defer to close rows to avoid scan panic leak rows

go-gorm · Mar 29, 2022 · ea8509b · ea8509b
1 parent 9dd6ed9
commit ea8509b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/callbacks/create.go b/callbacks/create.go
@@ -84,8 +84,10 @@ func Create(config *Config) func(db *gorm.DB) {
 				db.Statement.Context, db.Statement.SQL.String(), db.Statement.Vars...,
 			)
 			if db.AddError(err) == nil {
+				defer func() {
+					db.AddError(rows.Close())
+				}()
 				gorm.Scan(rows, db, mode)
-				db.AddError(rows.Close())
 			}
 
 			return

diff --git a/callbacks/query.go b/callbacks/query.go
@@ -20,8 +20,10 @@ func Query(db *gorm.DB) {
 				db.AddError(err)
 				return
 			}
+			defer func() {
+				db.AddError(rows.Close())
+			}()
 			gorm.Scan(rows, db, 0)
-			db.AddError(rows.Close())
 		}
 	}
 }