Skip to content

Commit

Permalink
fix: same embedded filed name (#5705)
Browse files Browse the repository at this point in the history
  • Loading branch information
a631807682 committed Sep 22, 2022
1 parent 4906259 commit 5ed7b1a
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 1 deletion.
2 changes: 1 addition & 1 deletion migrator/migrator.go
Expand Up @@ -478,7 +478,7 @@ func (m Migrator) MigrateColumn(value interface{}, field *schema.Field, columnTy
}

if alterColumn && !field.IgnoreMigration {
return m.DB.Migrator().AlterColumn(value, field.Name)
return m.DB.Migrator().AlterColumn(value, field.DBName)
}

return nil
Expand Down
38 changes: 38 additions & 0 deletions tests/migrate_test.go
Expand Up @@ -959,3 +959,41 @@ func TestMigrateArrayTypeModel(t *testing.T) {
AssertEqual(t, nil, err)
AssertEqual(t, "integer[]", ct.DatabaseTypeName())
}

func TestMigrateSameEmbeddedFieldName(t *testing.T) {
type UserStat struct {
GroundDestroyCount int
}

type GameUser struct {
gorm.Model
StatAb UserStat `gorm:"embedded;embeddedPrefix:stat_ab_"`
}

type UserStat1 struct {
GroundDestroyCount string
}

type GroundRate struct {
GroundDestroyCount int
}

type GameUser1 struct {
gorm.Model
StatAb UserStat1 `gorm:"embedded;embeddedPrefix:stat_ab_"`
GroundRateRb GroundRate `gorm:"embedded;embeddedPrefix:rate_ground_rb_"`
}

DB.Migrator().DropTable(&GameUser{})
err := DB.AutoMigrate(&GameUser{})
AssertEqual(t, nil, err)

err = DB.Table("game_users").AutoMigrate(&GameUser1{})
AssertEqual(t, nil, err)

_, err = findColumnType(&GameUser{}, "stat_ab_ground_destory_count")
AssertEqual(t, nil, err)

_, err = findColumnType(&GameUser{}, "rate_ground_rb_ground_destory_count")
AssertEqual(t, nil, err)
}

0 comments on commit 5ed7b1a

Please sign in to comment.