Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vendor] Fix Version Compare Lib #12735

Merged
merged 7 commits into from Sep 6, 2020
Merged

[Vendor] Fix Version Compare Lib #12735

merged 7 commits into from Sep 6, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 5, 2020

@6543 6543 added this to the 1.13.0 milestone Sep 5, 2020
@6543 6543 added dependencies type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 5, 2020
@6543
Copy link
Member Author

6543 commented Sep 5, 2020

upstream pull: hashicorp/go-version#77

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2020
techknowlogick
techknowlogick reviewed Sep 5, 2020
View reviewed changes
modules/git/git.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #12735 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12735   +/-   ##
=======================================
  Coverage   43.40%   43.40%           
=======================================
  Files         648      648           
  Lines       71548    71548           
=======================================
+ Hits        31053    31056    +3     
+ Misses      35468    35463    -5     
- Partials     5027     5029    +2
Impacted Files Coverage Δ
modules/git/git.go 40.00% <ø> (ø)
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/git/repo.go 49.74% <0.00%> (-1.02%) ⬇️
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
models/error.go 35.32% <0.00%> (+0.51%) ⬆️
services/pull/check.go 50.00% <0.00%> (+2.30%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78509b5...4f7a59d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2020
6543
6543 commented Sep 6, 2020
View reviewed changes
vendor/modules.txt Outdated Show resolved Hide resolved
vendor/modules.txt Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Sep 6, 2020

@techknowlogick thanks

@techknowlogick techknowlogick merged commit f10d3ea into go-gitea:master Sep 6, 2020
@6543 6543 deleted the fix-version-lib branch September 6, 2020 01:13
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

cheers fellows 🚀

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Gitea fails with non-release git version number (2.28.0.618.gf4bc123cb7)
6 participants
@6543 @codecov-commenter @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @techknowlogick @zeripath @GiteaBot