Decode push options in update request #968
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrumpylion
force-pushed
the
decode-push-options-update-request
branch
from
eae2f12
to
0c726c2
Compare
Signed-off-by: Nikolas Sepos <nikolas.sepos@gmail.com>
thegrumpylion
force-pushed
the
decode-push-options-update-request
branch
from
0c726c2
to
b353ec2
Compare
pjbgf
requested changes
Mar 6, 2024
Comment on lines
+78
to
+82
| func errInvalidPushOption(err error) error { | ||
| return errMalformedRequest(fmt.Sprintf( | ||
| "invalid push option: %s", err.Error())) | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| func errInvalidPushOption(err error) error { | |
| return errMalformedRequest(fmt.Sprintf( | |
| "invalid push option: %s", err.Error())) | |
| } |
| return &Option{Key: string(b)}, nil | ||
| } | ||
| if i == 0 { | ||
| return nil, errInvalidPushOption(errors.New("empty option key")) |
There was a problem hiding this comment.
Let's create an ErrInvalidPushOption var at the top of the file:
ErrInvalidPushOption = errors.New("invalid push option")
Suggested change
| return nil, errInvalidPushOption(errors.New("empty option key")) | |
| return nil, ErrInvalidPushOption |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.