Refactor transport and cleanup #938
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
transport-refactor
branch
9 times, most recently
from
34c00a3
to
755a2fd
Compare
This was referenced Nov 23, 2023
Closed
aymanbagabas
force-pushed
the
transport-refactor
branch
2 times, most recently
from
48df491
to
4ba86f9
Compare
aymanbagabas
force-pushed
the
transport-refactor
branch
from
4ba86f9
to
9a35c66
Compare
Git file, git, and ssh transports use a full-duplex transport protocol. This is now located under `plumbing/transport`. The server transport along with its `Serve*` methods are now located under `plumbing/server`.
* plumbing: pktline, dry parsing length and rename empty pkt * plumbing: pktline, implement pktline reader * plumbing: pktline, implement pktline writer * plumbing: pktline tests, add benchmarks * plumbing: pktline, deprecate the old impl and use pktline read/writer * plumbing: pktline, use static methods approach * plumbing: pktline, add WriteResponseEnd and method docs * plumbing: pktline, remove scanner/encoder * plumbing: pktline, update comment * plumbing: pktline, add benchmark tests * plumbing: pktline, error on nil writer * plumbing: pktline, update plumbing/protocol/packp/uppackresp.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> * plumbing: pktline, update plumbing/protocol/packp/report_status.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> * plumbing: pktline, update plumbing/protocol/packp/report_status.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> * plumbing: pktline, update plumbing/protocol/packp/gitproto.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> * plumbing: pktline, update plumbing/format/pktline/pktline_bench_test.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> * plumbing: packp, update imports * plumbing: pktline, add GetPacketBuffer and PutPacketBuffer * plumbing: pktline, use shared buffer with ReadPacketLine * plumbing: pktline, add scanner based type * plumbing: pktline, update benchmarks * plumbing: pktline, fix errors and improve perf and memory * plumbing: pktline, shorten method names Pktline is already implied in the package name, no need to have "Packet" in the method names. * plumbing: pktline, update plumbing/protocol/packp/advrefs_decode.go Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com> --------- Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
aymanbagabas
force-pushed
the
transport-refactor
branch
from
f18c35b
to
b30a900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transport sub-package is a fundamental part of the Go-Git project. Like Git, Go-Git supports the file, git, ssh, and HTTP transports. The file, git, and ssh transports use a shared full-duplex transfer protocol that can read/write on the same connection. HTTP on the other hand, uses a different implementation that uses a half-duplex but still with many common parts with the original transfer protocol.
TODO:
plumbing/transportplumbing/server