plumbing: commitgraph, add function to build graphs #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
reviewed
Oct 28, 2023
Comment on lines
174
to
176
| // Not in the graph yet | ||
| // OK so to add a node we need to check its parents | ||
| // If all of the parents are in the graph then we can add the node. |
There was a problem hiding this comment.
Suggested change
| // Not in the graph yet | |
| // OK so to add a node we need to check its parents | |
| // If all of the parents are in the graph then we can add the node. | |
| // The node is not in the graph yet. But to add it we first need to check its parents. | |
| // Only when all of the parents are in the graph that we can add the node. |
There was a problem hiding this comment.
Sorry about this I'd done quite a lot of rewriting of the comments - I think things should be a lot clearer in the rewrite!
zeripath
force-pushed
the
graph-creation
branch
from
cc6661c
to
b29e175
Compare
Make builder function for creating commitgraphs which could be written with the functionality in encoder.go. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
graph-creation
branch
from
b29e175
to
d709f7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make builder function for creating commitgraphs which could be written with the functionality in encoder.go.