New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: support insteadOf for remotes' URLs #79
Conversation
Great! I have a big concern if you check how behaves git, with instead, it is straight forward. The So I believe that we need to check the global/system configuration in the Additionally, we should at an option in |
ok, i will update the pr |
@kostyay |
I didn't have time to rewrite it yet. |
71d3f7f
to
54b3d68
Compare
@mcuadros I've updated the implementation following your comments. |
54b3d68
to
8193f4f
Compare
Hey, sorry that I'm being this person, but based on the discussion I feel like this slipped through the cracks. Any chance it could be reviewed again? Thank you! |
The repo maintainer never bothered reviewing it |
LGTM can you fix the conflicts @kostyay ? |
8193f4f
to
5db749a
Compare
Fixed |
Not sure why tests are failing.. flaky? |
Yup is a flaky test. |
Added support for insteadOf configuration for remote's urls.
Can also be applied to submodules, but I didn't implement that.
This fixes: #76