Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quotes around option values with hash in git config files #611

Closed
wants to merge 1 commit into from
Closed

Add quotes around option values with hash in git config files #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion plumbing/format/config/encoder.go
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@ func (e *Encoder) encodeSubsection(sectionName string, s *Subsection) error {
func (e *Encoder) encodeOptions(opts Options) error {
for _, o := range opts {
pattern := "\t%s = %s\n"
if strings.Contains(o.Value, "\\") {
if strings.Contains(o.Value, "\\") || strings.Contains(o.Value, "#") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more characters that could cause problems with config values.
Also see #354(plumbing: config, Branch name with hash can be cloned. Fixes #309) for an approved PR for this issue.

pattern = "\t%s = %q\n"
}

Expand Down