Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plumbing: packp, Avoid duplicate encoding when overriding a Capability value. #521

Merged
merged 1 commit into from Apr 30, 2022
Merged

plumbing: packp, Avoid duplicate encoding when overriding a Capability value. #521

merged 1 commit into from Apr 30, 2022

Commits on Apr 22, 2022

  1. plumbing: packp, Avoid duplicate encoding when overriding a Capabilit… 

    …y value.

Previously, calling `Set($CAPABILITY, ...)` on a `capability.List` where `$CAPABILITY`
was already present would correctly replace the existing value of that capability, but
would also result in that capability being listed twice in the internal `l.sort` slice.
This manifested publicly when the `List` was encoded as the same capability appearing
twice with the same value in the encoded output.
    @tylerchr
    tylerchr committed Apr 22, 2022
    Copy the full SHA
    6650ef8 View commit details
    Browse the repository at this point in the history